Skip to content

generate json pretty #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

generate json pretty #12

wants to merge 1 commit into from

Conversation

narukami894
Copy link

Hello, thank you for creating nice app and import tool!
I fixed json_generator.rb to build boostnote.json as same as Boostnote itself by using JSON.pretty_generate, and replace the order of json keys.

before:

{"folders":[{"key":"xxxx","name":"myFolderName","color":"#B013A4"},{"key":"yyyy","name":"myFolderName2","color":"#FF8E00"},(...)],"version":"1.0"}

after:

{
  "folders": [
    {
      "key": "xxxx",
      "color": "#3FD941",
      "name": "myFolderName"
    },
    {
      "key": "yyyy",
      "color": "#2BA5F7",
      "name": "myFolderName2"
    },
    (...)
  ],
  "version": "1.0"
}

@narukami894 narukami894 mentioned this pull request Mar 1, 2018
Merged
asmsuechan
asmsuechan approved these changes Mar 23, 2018
View reviewed changes
Copy link
Contributor

@asmsuechan asmsuechan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @narukami894. Sorry for my long absence and thank you very much for your improvement!
LGTM

@asmsuechan
Copy link
Contributor

GOSH. I don't have merge authorization...

@asmsuechan
Copy link
Contributor

asmsuechan commented Mar 23, 2018 •
edited
Loading

Excuse me, @Rokt33r. Will you please merge opening 2 PRs and remove this line

ever2boost/.travis.yml

Line 7 in 17be2a8

- 2.0.0
?

The reason why I tried to support even Ruby2.0 is that because it's pre-installed version of Ruby on macOS. So I'd say it's not good to remove compatibility with it.

@Rokt33r
Copy link
Member

Rokt33r commented Mar 23, 2018

@asmsuechan I've invited you as an admin to this repository. Check your e-mail. 😄

@IssueHuntBot
Copy link

@opengift-io has started working. Visit this issue on Issuehunt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@asmsuechan asmsuechan asmsuechan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@narukami894 @asmsuechan @Rokt33r @IssueHuntBot